Skip to content

[ZEPPELIN-1875] permission dialog code is not stable #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cloverhearts wants to merge 2 commits into from
Closed

[ZEPPELIN-1875] permission dialog code is not stable #1821

cloverhearts wants to merge 2 commits into from

Conversation

@cloverhearts
Copy link
Member

@cloverhearts cloverhearts commented Dec 29, 2016

What is this PR for?

The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.

What type of PR is it?

Bug Fix , Improvement

Todos

  • changed method name (getBlockNotAuthenticatedUserErrorMsg)
  • permission dialog pop-up change logic.
  • added check logic for anonymous user in checkIfUserIsAnon method

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1875

How should this be tested?

  1. when you do have turn on the shiro and login and click to note permission button.
  2. or turn off the shiro.

Screenshots (if appropriate)

dialog

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Dec 30, 2016

@cloverhearts Thanks for quick fixing and improvement. I think it's my bad.. Let me test this!

But Selenium test failure looks relevant with this change like below. Could you take a look?

Results :

Tests in error: 
  AuthenticationIT.testGroupPermission:192->AbstractZeppelinIT.pollingWait:96 » Timeout

Tests run: 18, Failures: 0, Errors: 1, Skipped: 0

This is the screenshot taken when the error occurs
copy

@cloverhearts
Copy link
Member Author

cloverhearts commented Dec 30, 2016

@AhyoungRyu Okay, I will check it.
Thank you for your feedback.

@cloverhearts cloverhearts reopened this Dec 30, 2016
@cloverhearts
Copy link
Member Author

cloverhearts commented Jan 1, 2017

fixed.
@AhyoungRyu Could you please review again? :)

@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Jan 1, 2017

@cloverhearts yup. Thanks!

@cloverhearts cloverhearts mentioned this pull request Jan 1, 2017
Closed
1 task
@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Jan 2, 2017

Tested this branch and checked the verbose forbidden error messages(my bad..) are totally gone when I turned off Shiro. Thanks @cloverhearts!
LGTM 👍

@Leemoonsoo
Copy link
Member

Leemoonsoo commented Jan 2, 2017

Tested and LGTM

@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Jan 3, 2017

Then will merge into master if there are no more comments

@asfgit asfgit closed this in f83d012 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloverhearts @AhyoungRyu @Leemoonsoo